Use Molecule for testing (#158)

* Ported test playbooks to Molecule scenarios

* Update Travis integration

* Delete legacy tests

.gitignore

@@ -2,3 +2,4 @@
 ############################
 *.crt
 *.key
+__pycache__

.travis.yml

@@ -1,215 +1,13 @@
 ---
 sudo: required
+language: python
 services:
   - docker
-matrix:
-  include:
-    - env:
-        distribution: centos
-        version: 6
-        playbook: basic
-    - env:
-        distribution: centos
-        version: 6
-        playbook: http-template
-    - env:
-        distribution: centos
-        version: 6
-        playbook: modules
-    - env:
-        distribution: centos
-        version: 6
-        playbook: push
-    - env:
-        distribution: centos
-        version: 6
-        playbook: stable
-    - env:
-        distribution: centos
-        version: 6
-        playbook: stream-template
-    - env:
-        distribution: centos
-        version: 6
-        playbook: unit
-    - env:
-        distribution: centos
-        version: 7
-        playbook: basic
-    - env:
-        distribution: centos
-        version: 7
-        playbook: http-template
-    - env:
-        distribution: centos
-        version: 7
-        playbook: modules
-    - env:
-        distribution: centos
-        version: 7
-        playbook: push
-    - env:
-        distribution: centos
-        version: 7
-        playbook: stable
-    - env:
-        distribution: centos
-        version: 7
-        playbook: stream-template
-    - env:
-        distribution: centos
-        version: 7
-        playbook: unit
-    - env:
-        distribution: debian
-        version: jessie
-        playbook: basic
-    - env:
-        distribution: debian
-        version: jessie
-        playbook: http-template
-    - env:
-        distribution: debian
-        version: jessie
-        playbook: modules
-    - env:
-        distribution: debian
-        version: jessie
-        playbook: push
-    - env:
-        distribution: debian
-        version: jessie
-        playbook: stable
-    - env:
-        distribution: debian
-        version: jessie
-        playbook: stream-template
-    - env:
-        distribution: debian
-        version: jessie
-        playbook: unit
-    - env:
-        distribution: debian
-        version: stretch
-        playbook: basic
-    - env:
-        distribution: debian
-        version: stretch
-        playbook: http-template
-    - env:
-        distribution: debian
-        version: stretch
-        playbook: modules
-    - env:
-        distribution: debian
-        version: stretch
-        playbook: push
-    - env:
-        distribution: debian
-        version: stretch
-        playbook: stable
-    - env:
-        distribution: debian
-        version: stretch
-        playbook: stream-template
-    - env:
-        distribution: debian
-        version: stretch
-        playbook: unit
-    - env:
-        distribution: ubuntu
-        version: trusty
-        playbook: basic
-    - env:
-        distribution: ubuntu
-        version: trusty
-        playbook: http-template
-    - env:
-        distribution: ubuntu
-        version: trusty
-        playbook: modules
-    - env:
-        distribution: ubuntu
-        version: trusty
-        playbook: push
-    - env:
-        distribution: ubuntu
-        version: trusty
-        playbook: stable
-    - env:
-        distribution: ubuntu
-        version: trusty
-        playbook: stream-template
-    - env:
-        distribution: ubuntu
-        version: xenial
-        playbook: basic
-    - env:
-        distribution: ubuntu
-        version: xenial
-        playbook: http-template
-    - env:
-        distribution: ubuntu
-        version: xenial
-        playbook: modules
-    - env:
-        distribution: ubuntu
-        version: xenial
-        playbook: push
-    - env:
-        distribution: ubuntu
-        version: xenial
-        playbook: stable
-    - env:
-        distribution: ubuntu
-        version: xenial
-        playbook: stream-template
-    - env:
-        distribution: ubuntu
-        version: xenial
-        playbook: unit
-    - env:
-        distribution: ubuntu
-        version: bionic
-        playbook: basic
-    - env:
-        distribution: ubuntu
-        version: bionic
-        playbook: http-template
-    - env:
-        distribution: ubuntu
-        version: bionic
-        playbook: modules
-    - env:
-        distribution: ubuntu
-        version: bionic
-        playbook: push
-    - env:
-        distribution: ubuntu
-        version: bionic
-        playbook: stable
-    - env:
-        distribution: ubuntu
-        version: bionic
-        playbook: stream-template
-    - env:
-        distribution: ubuntu
-        version: bionic
-        playbook: unit
 before_install:
-  - 'sudo docker pull ${distribution}:${version}'
-  - 'sudo docker build --no-cache --rm --file=tests/dockerfiles/Dockerfile.${distribution}-${version} --tag=${distribution}-${version}:ansible tests'
+  - sudo apt-get -qq update
+install:
+  - pip install molecule[docker]
 script:
-  - container_id=$(mktemp)
-  - 'sudo docker run --detach --privileged -v /sys/fs/cgroup:/sys/fs/cgroup:ro --volume="${PWD}":/etc/ansible/roles/ansible-role-nginx:ro ${distribution}-${version}:ansible > "${container_id}"'
-  - 'sudo docker exec "$(cat ${container_id})" env ANSIBLE_FORCE_COLOR=1 ansible-playbook -v /etc/ansible/roles/ansible-role-nginx/tests/playbooks/nginx-${playbook}.yml --syntax-check'
-  - 'sudo docker exec "$(cat ${container_id})" env ANSIBLE_FORCE_COLOR=1 ansible-playbook -v /etc/ansible/roles/ansible-role-nginx/tests/playbooks/nginx-${playbook}.yml'
-  - >
-    sudo docker exec "$(cat ${container_id})" env ANSIBLE_FORCE_COLOR=1 ansible-playbook -v /etc/ansible/roles/ansible-role-nginx/tests/playbooks/nginx-${playbook}.yml
-    | grep -q 'changed=0.*failed=0'
-    && (echo 'Idempotence test: pass' && exit 0)
-    || (echo 'Idempotence test: fail' && exit 1)
-  - 'if [${playbook} != "unit"]; then sudo docker exec "$(cat ${container_id})" curl http://localhost/; fi'
-  - 'sudo docker rm -f "$(cat ${container_id})"'
+  - molecule test --all
 notifications:
   webhooks: https://galaxy.ansible.com/api/v1/notifications/

.yamllint

@@ -0,0 +1,13 @@
+extends: default
+
+rules:
+  braces:
+    max-spaces-inside: 1
+    level: error
+  brackets:
+    max-spaces-inside: 1
+    level: error
+  comments: disable
+  comments-indentation: disable
+  line-length: disable
+  truthy: disable

handlers/main.yml

@@ -13,26 +13,26 @@
         name: nginx
         state: reloaded
 
-    - name: "(Handler: All OSs) Start NGINX Amplify Agent"
-      service:
-        name: amplify-agent
-        state: started
-
-    - name: "(Handler: All OSs) Start NGINX Controller Agent"
-      service:
-        name: controller-agent
-        state: started
-
-    - name: "(Handler: Debian/Ubuntu/CentOS/RedHat) Start NGINX Unit"
-      service:
-        name: unit
-        state: started
-        enabled: yes
-
-    - name: "(Handler: FreeBSD) Start NGINX Unit"
-      service:
-        name: unitd
-        state: started
-        enabled: yes
-
   when: nginx_start | bool
+
+- name: "(Handler: All OSs) Start NGINX Amplify Agent"
+  service:
+    name: amplify-agent
+    state: started
+
+- name: "(Handler: All OSs) Start NGINX Controller Agent"
+  service:
+    name: controller-agent
+    state: started
+
+- name: "(Handler: Debian/Ubuntu/CentOS/RedHat) Start NGINX Unit"
+  service:
+    name: unit
+    state: started
+    enabled: yes
+
+- name: "(Handler: FreeBSD) Start NGINX Unit"
+  service:
+    name: unitd
+    state: started
+    enabled: yes

molecule/default/Dockerfile.j2

@@ -0,0 +1,14 @@
+# Molecule managed
+
+{% if item.registry is defined %}
+FROM {{ item.registry.url }}/{{ item.image }}
+{% else %}
+FROM {{ item.image }}
+{% endif %}
+
+RUN if [ $(command -v apt-get) ]; then apt-get update && apt-get install -y curl python sudo bash ca-certificates && apt-get clean; \
+    elif [ $(command -v dnf) ]; then dnf makecache && dnf --assumeyes install python sudo python-devel python*-dnf bash && dnf clean all; \
+    elif [ $(command -v yum) ]; then yum makecache fast && yum install -y epel-release python sudo yum-plugin-ovl bash && sed -i 's/plugins=0/plugins=1/g' /etc/yum.conf && yum clean all; \
+    elif [ $(command -v zypper) ]; then zypper refresh && zypper install -y python sudo bash python-xml && zypper clean -a; \
+    elif [ $(command -v apk) ]; then apk update && apk add --no-cache python sudo bash ca-certificates; \
+    elif [ $(command -v xbps-install) ]; then xbps-install -Syu && xbps-install -y python sudo bash ca-certificates && xbps-remove -O; fi

molecule/default/molecule.yml

@@ -0,0 +1,30 @@
+---
+driver:
+  name: docker
+lint:
+  name: yamllint
+platforms:
+  - name: centos-6
+    image: centos:6
+  - name: centos-7
+    image: centos/systemd
+    privileged: True
+    volume_mounts:
+      - "/sys/fs/cgroup:/sys/fs/cgroup:rw"
+    command: "/usr/sbin/init"
+  - name: debian-jessie
+    image: debian:jessie
+  - name: debian-stretch
+    image: debian:stretch
+  - name: ubuntu-xenial
+    image: ubuntu:xenial
+  - name: ubuntu-bionic
+    image: ubuntu:bionic
+provisioner:
+  name: ansible
+  lint:
+    name: ansible-lint
+verifier:
+  name: testinfra
+  lint:
+    name: flake8

molecule/default/playbook.yml

@@ -0,0 +1,5 @@
+---
+- name: Converge
+  hosts: all
+  roles:
+    - role: ansible-role-nginx

molecule/default/tests/test_default.py

@@ -0,0 +1,30 @@
+import os
+
+import testinfra.utils.ansible_runner
+
+testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner(
+    os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('all')
+
+
+def test_nginx_is_installed(host):
+    ngx = host.package("nginx")
+    assert ngx.is_installed
+
+
+def test_nginx_running_and_enabled(host):
+    ngx = host.service("nginx")
+    assert ngx.is_running
+    assert ngx.is_enabled
+
+
+def test_hosts_file(host):
+    ngx = host.file('/etc/hosts')
+    assert ngx.exists
+    assert ngx.user == 'root'
+    assert ngx.group == 'root'
+
+
+def test_endpoint(host):
+    command = """curl -I http://localhost/"""
+    cmd = host.run(command)
+    assert '200 OK' in cmd.stdout

molecule/stable_push/Dockerfile.j2

@@ -0,0 +1,14 @@
+# Molecule managed
+
+{% if item.registry is defined %}
+FROM {{ item.registry.url }}/{{ item.image }}
+{% else %}
+FROM {{ item.image }}
+{% endif %}
+
+RUN if [ $(command -v apt-get) ]; then apt-get update && apt-get install -y curl python sudo bash ca-certificates && apt-get clean; \
+    elif [ $(command -v dnf) ]; then dnf makecache && dnf --assumeyes install python sudo python-devel python*-dnf bash && dnf clean all; \
+    elif [ $(command -v yum) ]; then yum makecache fast && yum install -y epel-release python sudo yum-plugin-ovl bash && sed -i 's/plugins=0/plugins=1/g' /etc/yum.conf && yum clean all; \
+    elif [ $(command -v zypper) ]; then zypper refresh && zypper install -y python sudo bash python-xml && zypper clean -a; \
+    elif [ $(command -v apk) ]; then apk update && apk add --no-cache python sudo bash ca-certificates; \
+    elif [ $(command -v xbps-install) ]; then xbps-install -Syu && xbps-install -y python sudo bash ca-certificates && xbps-remove -O; fi

molecule/stable_push/files/http/default.conf

@@ -1,5 +1,5 @@
 server {
-    listen       8080;
+    listen       80;
     server_name  localhost;
 
     #charset koi8-r;

molecule/stable_push/molecule.yml

@@ -0,0 +1,33 @@
+---
+dependency:
+  name: shell
+  command: pip install python-nginx
+driver:
+  name: docker
+lint:
+  name: yamllint
+platforms:
+  - name: centos-6
+    image: centos:6
+  - name: centos-7
+    image: centos/systemd
+    privileged: True
+    volume_mounts:
+      - "/sys/fs/cgroup:/sys/fs/cgroup:rw"
+    command: "/usr/sbin/init"
+  - name: debian-jessie
+    image: debian:jessie
+  - name: debian-stretch
+    image: debian:stretch
+  - name: ubuntu-xenial
+    image: ubuntu:xenial
+  - name: ubuntu-bionic
+    image: ubuntu:bionic
+provisioner:
+  name: ansible
+  lint:
+    name: ansible-lint
+verifier:
+  name: testinfra
+  lint:
+    name: flake8

molecule/stable_push/playbook.yml

@@ -0,0 +1,11 @@
+---
+- name: Converge
+  hosts: all
+  roles:
+    - role: ansible-role-nginx
+  vars:
+    nginx_branch: stable
+    nginx_main_upload_enable: true
+    nginx_main_upload_src: files/nginx.conf
+    nginx_http_upload_enable: true
+    nginx_http_upload_src: files/http/*.conf

molecule/stable_push/tests/test_default.py

@@ -0,0 +1,41 @@
+import nginx
+import os
+
+import testinfra.utils.ansible_runner
+
+testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner(os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('all') # noqa E501
+
+
+def test_nginx_is_installed(host):
+    ngx = host.package("nginx")
+    assert ngx.is_installed
+
+
+def test_nginx_running_and_enabled(host):
+    ngx = host.service("nginx")
+    assert ngx.is_running
+    assert ngx.is_enabled
+
+
+def test_hosts_file(host):
+    ngx = host.file('/etc/hosts')
+    assert ngx.exists
+    assert ngx.user == 'root'
+    assert ngx.group == 'root'
+
+
+def test_endpoint(host):
+    command = """curl -I http://localhost/"""
+    cmd = host.run(command)
+    assert '200 OK' in cmd.stdout
+
+
+def test_generated_files(host):
+    assert host.file('/etc/nginx/conf.d/default.conf').exists
+
+
+def test_default_server(host):
+    f = host.file('/etc/nginx/conf.d/default.conf')
+    c = nginx.loads(f.content_string)
+    lf = c.server.filter('Location', '/')
+    assert len(lf) == 1

molecule/template_module/Dockerfile.j2

@@ -0,0 +1,14 @@
+# Molecule managed
+
+{% if item.registry is defined %}
+FROM {{ item.registry.url }}/{{ item.image }}
+{% else %}
+FROM {{ item.image }}
+{% endif %}
+
+RUN if [ $(command -v apt-get) ]; then apt-get update && apt-get install -y curl python sudo bash ca-certificates && apt-get clean; \
+    elif [ $(command -v dnf) ]; then dnf makecache && dnf --assumeyes install python sudo python-devel python*-dnf bash && dnf clean all; \
+    elif [ $(command -v yum) ]; then yum makecache fast && yum install -y epel-release python sudo yum-plugin-ovl bash && sed -i 's/plugins=0/plugins=1/g' /etc/yum.conf && yum clean all; \
+    elif [ $(command -v zypper) ]; then zypper refresh && zypper install -y python sudo bash python-xml && zypper clean -a; \
+    elif [ $(command -v apk) ]; then apk update && apk add --no-cache python sudo bash ca-certificates; \
+    elif [ $(command -v xbps-install) ]; then xbps-install -Syu && xbps-install -y python sudo bash ca-certificates && xbps-remove -O; fi

molecule/template_module/molecule.yml

@@ -0,0 +1,33 @@
+---
+dependency:
+  name: shell
+  command: pip install python-nginx
+driver:
+  name: docker
+lint:
+  name: yamllint
+platforms:
+  - name: centos-6
+    image: centos:6
+  - name: centos-7
+    image: centos/systemd
+    privileged: True
+    volume_mounts:
+      - "/sys/fs/cgroup:/sys/fs/cgroup:rw"
+    command: "/usr/sbin/init"
+  - name: debian-jessie
+    image: debian:jessie
+  - name: debian-stretch
+    image: debian:stretch
+  - name: ubuntu-xenial
+    image: ubuntu:xenial
+  - name: ubuntu-bionic
+    image: ubuntu:bionic
+provisioner:
+  name: ansible
+  lint:
+    name: ansible-lint
+verifier:
+  name: testinfra
+  lint:
+    name: flake8

molecule/template_module/playbook.yml

@@ -0,0 +1,270 @@
+---
+- name: Converge
+  hosts: all
+  roles:
+    - role: ansible-role-nginx
+  vars:
+    nginx_debug_output: true
+
+    nginx_main_template_enable: true
+    nginx_main_template:
+      template_file: nginx.conf.j2
+      conf_file_name: nginx.conf
+      conf_file_location: /etc/nginx/
+      user: nginx
+      worker_processes: auto
+      error_level: warn
+      worker_connections: 1024
+      http_enable: true
+      http_settings:
+        keepalive_timeout: 65
+        cache: false
+        rate_limit: false
+        keyval: false
+      stream_enable: true
+      http_global_autoindex: false
+
+    nginx_http_template_enable: true
+    nginx_http_template:
+      app:
+        template_file: http/default.conf.j2
+        conf_file_name: default.conf
+        conf_file_location: /etc/nginx/conf.d/
+        listen:
+          listen_localhost:
+            ip: 0.0.0.0
+            port: 80
+            opts:
+              - default_server
+        server_name: localhost
+        error_page: /usr/share/nginx/html
+        client_max_body_size: 512k
+        proxy_hide_headers:
+          - X-Powered-By
+        add_headers:
+          strict_transport_security:
+            name: Strict-Transport-Security
+            value: max-age=15768000; includeSubDomains
+            always: true
+        reverse_proxy:
+          proxy_cache_path:
+            - path: /var/cache/nginx/proxy/frontend
+              keys_zone:
+                name: frontend_proxy_cache
+                size: 5m
+              levels: "1:2"
+              max_size: 5g
+              inactive: 30m
+              use_temp_path: true
+            - path: /var/cache/nginx/proxy/backend
+              keys_zone:
+                name: backend_proxy_cache
+                size: 10m
+              levels: "1:2"
+              max_size: 10g
+              inactive: 60m
+              use_temp_path: true
+          proxy_temp_path:
+            path: /var/cache/nginx/proxy/temp
+          proxy_cache_lock: true
+          proxy_cache_min_uses: 5
+          proxy_cache_revalidate: true
+          proxy_cache_use_stale:
+            - error
+            - timeout
+          proxy_ignore_headers:
+            - Expires
+          locations:
+            frontend:
+              location: /
+              proxy_hide_headers:
+                - X-Powered-By
+              add_headers:
+                strict_transport_security:
+                  name: Strict-Transport-Security
+                  value: max-age=15768000; includeSubDomains
+                  always: true
+                another_header:
+                  name: Fancy-New-Header-To-Test
+                  value: testing=true
+                  always: false
+              proxy_pass: http://frontend_servers/
+              proxy_cache: frontend_proxy_cache
+              proxy_temp_path:
+                path: /var/cache/nginx/proxy/frontend/temp
+              proxy_cache_lock: false
+              proxy_cache_min_uses: 3
+              proxy_cache_revalidate: false
+              proxy_cache_use_stale:
+                - http_403
+                - http_404
+              proxy_ignore_headers:
+                - Vary
+                - Cache-Control
+              proxy_redirect: false
+              proxy_set_header:
+                header_host:
+                  name: Host
+                  value: $host
+                header_x_real_ip:
+                  name: X-Real-IP
+                  value: $remote_addr
+                header_x_forwarded_for:
+                  name: X-Forwarded-For
+                  value: $proxy_add_x_forwarded_for
+                header_x_forwarded_proto:
+                  name: X-Forwarded-Proto
+                  value: $scheme
+              proxy_buffering: false
+              client_max_body_size: 5m
+            backend:
+              location: /backend
+              proxy_pass: http://backend_servers/
+              proxy_cache: backend_proxy_cache
+              proxy_temp_path:
+                path: /var/cache/nginx/proxy/backend/temp
+              proxy_cache_lock: true
+              proxy_cache_min_uses: 2
+              proxy_cache_revalidate: true
+              proxy_cache_use_stale:
+                - http_500
+                - http_502
+                - http_503
+              proxy_redirect: default
+              proxy_set_header:
+                header_host:
+                  name: Host
+                  value: $host
+                header_x_real_ip:
+                  name: X-Real-IP
+                  value: $remote_addr
+                header_x_forwarded_for:
+                  name: X-Forwarded-For
+                  value: $proxy_add_x_forwarded_for
+                header_x_forwarded_proto:
+                  name: X-Forwarded-Proto
+                  value: $scheme
+              proxy_cookie_path:
+                path: /web/
+                replacement: /
+        upstreams:
+          frontend_upstream:
+            name: frontend_servers
+            lb_method: least_conn
+            zone_name: frontend_mem_zone
+            zone_size: 64k
+            sticky_cookie: false
+            servers:
+              frontend_server_1:
+                address: 0.0.0.0
+                port: 8081
+                weight: 1
+                health_check: max_fails=3 fail_timeout=5s
+          backend_upstream:
+            name: backend_servers
+            lb_method: least_conn
+            zone_name: backend_mem_zone
+            zone_size: 64k
+            sticky_cookie: false
+            servers:
+              backend_server_1:
+                address: 0.0.0.0
+                port: 8082
+                weight: 1
+                health_check: max_fails=3 fail_timeout=5s
+        returns:
+          return301:
+            location: ^~ /old-path
+            code: 301
+            value: http://$host/new-path
+      frontend:
+        template_file: http/default.conf.j2
+        conf_file_name: frontend_default.conf
+        conf_file_location: /etc/nginx/conf.d/
+        listen:
+          listen_localhost:
+            port: 8081
+            opts: []
+        server_name: localhost
+        error_page: /usr/share/nginx/html
+        autoindex: false
+        web_server:
+          locations:
+            frontend_site:
+              location: /
+              proxy_hide_headers:
+                - X-Powered-By
+              html_file_location: /usr/share/nginx/html
+              html_file_name: frontend_index.html
+              autoindex: false
+          http_demo_conf: true
+      backend:
+        template_file: http/default.conf.j2
+        conf_file_name: backend_default.conf
+        conf_file_location: /etc/nginx/conf.d/
+        listen:
+          listen_localhost:
+            port: 8082
+            opts: []
+        server_name: localhost
+        error_page: /usr/share/nginx/html
+        autoindex: false
+        web_server:
+          locations:
+            backend_site:
+              location: /
+              html_file_location: /usr/share/nginx/html
+              html_file_name: backend_index.html
+              autoindex: false
+          http_demo_conf: true
+    nginx_html_demo_template_enable: true
+    nginx_html_demo_template:
+      frontend:
+        template_file: www/index.html.j2
+        html_file_name: frontend_index.html
+        html_file_location: /usr/share/nginx/html
+        web_server_name: Frontend
+      backend:
+        template_file: www/index.html.j2
+        html_file_name: backend_index.html
+        html_file_location: /usr/share/nginx/html
+        web_server_name: Backend
+
+    nginx_stream_template_enable: true
+    nginx_stream_template:
+      default:
+        template_file: stream/default.conf.j2
+        conf_file_name: default.conf
+        conf_file_location: /etc/nginx/conf.d/stream
+        network_streams:
+          app:
+            listen_address: 0.0.0.0
+            listen_port: 8090
+            udp_enable: false
+            proxy_pass: backend
+            proxy_timeout: 3s
+            proxy_connect_timeout: 1s
+            proxy_protocol: false
+            health_check_plus: false
+        upstreams:
+          backend_upstream:
+            name: backend
+            lb_method: least_conn
+            zone_name: backend
+            zone_size: 64k
+            sticky_cookie: false
+            servers:
+              backend_server_1:
+                address: 0.0.0.0
+                port: 8091
+                weight: 1
+                health_check: max_fails=1 fail_timeout=10s
+
+    nginx_modules:
+      njs: true
+      perl: true
+      waf: false
+      geoip: true
+      image_filter: true
+      rtmp: true
+      xslt: true

molecule/template_module/tests/test_default.py

@@ -0,0 +1,57 @@
+import nginx
+import os
+
+import testinfra.utils.ansible_runner
+
+testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner(os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('all') # noqa E501
+
+
+def test_nginx_is_installed(host):
+    ngx = host.package("nginx")
+    assert ngx.is_installed
+
+
+def test_nginx_running_and_enabled(host):
+    ngx = host.service("nginx")
+    assert ngx.is_running
+    assert ngx.is_enabled
+
+
+def test_hosts_file(host):
+    ngx = host.file('/etc/hosts')
+    assert ngx.exists
+    assert ngx.user == 'root'
+    assert ngx.group == 'root'
+
+
+def test_endpoint(host):
+    command = """curl -I http://localhost/"""
+    cmd = host.run(command)
+    assert '200 OK' in cmd.stdout
+
+
+def test_generated_files(host):
+    assert host.file('/etc/nginx/conf.d/default.conf').exists
+    assert host.file('/etc/nginx/conf.d/frontend_default.conf').exists
+    assert host.file('/etc/nginx/conf.d/backend_default.conf').exists
+
+
+def test_default_server(host):
+    f = host.file('/etc/nginx/conf.d/default.conf')
+    c = nginx.loads(f.content_string)
+    lf = c.server.filter('Location', '/')
+    assert len(lf) == 1
+    lb = c.server.filter('Location', '/backend')
+    assert len(lb) == 1
+
+
+def test_client_max_body_size(host):
+    f = host.file('/etc/nginx/conf.d/default.conf')
+    c = nginx.loads(f.content_string)
+    vs = c.server.filter('Key', 'client_max_body_size')
+    assert len(vs) == 1
+    assert vs[0].value == '512k'
+    lc = c.server.filter('Location', '/')
+    vl = lc[0].filter('Key', 'client_max_body_size')
+    assert len(vl) == 1
+    assert vl[0].value == '5m'

molecule/unit/Dockerfile.j2

@@ -0,0 +1,14 @@
+# Molecule managed
+
+{% if item.registry is defined %}
+FROM {{ item.registry.url }}/{{ item.image }}
+{% else %}
+FROM {{ item.image }}
+{% endif %}
+
+RUN if [ $(command -v apt-get) ]; then apt-get update && apt-get install -y curl python sudo bash ca-certificates && apt-get clean; \
+    elif [ $(command -v dnf) ]; then dnf makecache && dnf --assumeyes install python sudo python-devel python*-dnf bash && dnf clean all; \
+    elif [ $(command -v yum) ]; then yum makecache fast && yum install -y epel-release python sudo yum-plugin-ovl bash && sed -i 's/plugins=0/plugins=1/g' /etc/yum.conf && yum clean all; \
+    elif [ $(command -v zypper) ]; then zypper refresh && zypper install -y python sudo bash python-xml && zypper clean -a; \
+    elif [ $(command -v apk) ]; then apk update && apk add --no-cache python sudo bash ca-certificates; \
+    elif [ $(command -v xbps-install) ]; then xbps-install -Syu && xbps-install -y python sudo bash ca-certificates && xbps-remove -O; fi

molecule/unit/molecule.yml

@@ -0,0 +1,26 @@
+---
+driver:
+  name: docker
+lint:
+  name: yamllint
+platforms:
+  - name: centos-6
+    image: centos:6
+  - name: centos-7
+    image: centos/systemd
+    privileged: True
+    volume_mounts:
+      - "/sys/fs/cgroup:/sys/fs/cgroup:rw"
+    command: "/usr/sbin/init"
+  - name: debian-jessie
+    image: debian:jessie
+  - name: debian-stretch
+    image: debian:stretch
+  - name: ubuntu-xenial
+    image: ubuntu:xenial
+  - name: ubuntu-bionic
+    image: ubuntu:bionic
+provisioner:
+  name: ansible
+  lint:
+    name: ansible-lint

molecule/unit/playbook.yml

@@ -1,9 +1,8 @@
 ---
-- hosts: localhost
-  become: true
-  remote_user: root
+- name: Converge
+  hosts: all
   roles:
-    - ansible-role-nginx
+    - role: ansible-role-nginx
   vars:
     nginx_enable: false
     nginx_unit_enable: true

tasks/main.yml

@@ -33,9 +33,6 @@
     - import_tasks: conf/cleanup-config.yml
       when: nginx_cleanup_config | bool
 
-    - import_tasks: modules/install-modules.yml
-      when: true in nginx_modules.values()
-
     - import_tasks: conf/upload-config.yml
       when: nginx_main_upload_enable
             or nginx_http_upload_enable
@@ -52,6 +49,9 @@
     - import_tasks: conf/setup-status.yml
       when: nginx_status_enable | bool
 
+    - import_tasks: modules/install-modules.yml
+      when: true in nginx_modules.values()
+
     - import_tasks: conf/debug-output.yml
       when: nginx_debug_output | bool
 

tasks/modules/install-geoip.yml

@@ -19,4 +19,5 @@
   with_items:
     - load_module modules/ngx_http_geoip_module.so;
     - load_module modules/ngx_stream_geoip_module.so;
+  when: not nginx_main_template_enable
   notify: "(Handler: All OSs) Reload NGINX"

tasks/modules/install-image-filter.yml

@@ -16,4 +16,5 @@
     path: /etc/nginx/nginx.conf
     insertbefore: BOF
     line: load_module modules/ngx_http_image_filter_module.so;
+  when: not nginx_main_template_enable
   notify: "(Handler: All OSs) Reload NGINX"

tasks/modules/install-njs.yml

@@ -19,4 +19,5 @@
   with_items:
     - load_module modules/ngx_http_js_module.so;
     - load_module modules/ngx_stream_js_module.so;
+  when: not nginx_main_template_enable
   notify: "(Handler: All OSs) Reload NGINX"

tasks/modules/install-perl.yml

@@ -16,4 +16,5 @@
     path: /etc/nginx/nginx.conf
     insertbefore: BOF
     line: load_module modules/ngx_http_perl_module.so;
+  when: not nginx_main_template_enable
   notify: "(Handler: All OSs) Reload NGINX"

tasks/modules/install-rtmp.yml

@@ -9,4 +9,5 @@
     path: /etc/nginx/nginx.conf
     insertbefore: BOF
     line: load_module modules/ngx_rtmp_module.so;
+  when: not nginx_main_template_enable
   notify: "(Handler: All OSs) Reload NGINX"

tasks/modules/install-waf.yml

@@ -9,4 +9,5 @@
     path: /etc/nginx/nginx.conf
     insertbefore: BOF
     line: load_module modules/ngx_http_modsecurity_module.so;
+  when: not nginx_main_template_enable
   notify: "(Handler: All OSs) Reload NGINX"

tasks/modules/install-xslt.yml

@@ -16,4 +16,5 @@
     path: /etc/nginx/nginx.conf
     insertbefore: BOF
     line: load_module modules/ngx_http_xslt_filter_module.so;
+  when: not nginx_main_template_enable
   notify: "(Handler: All OSs) Reload NGINX"

templates/nginx.conf.j2

@@ -1,5 +1,36 @@
 {{ ansible_managed | comment }}
 
+{% if nginx_modules.njs %}
+{% if nginx_http_template_enable %}
+load_module modules/ngx_http_js_module.so;
+{% endif %}
+{% if nginx_stream_template_enable %}
+load_module modules/ngx_stream_js_module.so;
+{% endif %}
+{% endif %}
+{% if nginx_modules.perl %}
+load_module modules/ngx_http_perl_module.so;
+{% endif %}
+{% if nginx_modules.geoip %}
+{% if nginx_http_template_enable %}
+load_module modules/ngx_http_geoip_module.so;
+{% endif %}
+{% if nginx_stream_template_enable %}
+load_module modules/ngx_stream_geoip_module.so;
+{% endif %}
+{% endif %}
+{% if nginx_modules.image_filter %}
+load_module modules/ngx_http_image_filter_module.so;
+{% endif %}
+{% if nginx_modules.rtmp and nginx_type == "plus" %}
+load_module modules/ngx_rtmp_module.so;
+{% endif %}
+{% if nginx_modules.xslt %}
+load_module modules/ngx_http_xslt_filter_module.so;
+{% endif %}
+{% if nginx_modules.waf and nginx_type == "plus" %}
+load_module modules/ngx_http_modsecurity_module.so;
+{% endif %}
 user  {{ nginx_main_template.user }};
 worker_processes  {{ nginx_main_template.worker_processes }};
 

tests/dockerfiles/Dockerfile.centos-6

@@ -1,12 +0,0 @@
-FROM centos:6
-
-RUN yum -y install epel-release
-RUN yum -y install git ansible sudo
-
-RUN sed -i -e 's/^\(Defaults\s*requiretty\)/#--- \1/'  /etc/sudoers
-
-RUN echo -e '[local]\nlocalhost ansible_connection=local' > /etc/ansible/hosts
-
-VOLUME ["/sys/fs/cgroup"]
-
-CMD ["/sbin/init"]

tests/dockerfiles/Dockerfile.centos-7

@@ -1,24 +0,0 @@
-FROM centos:7
-
-# Install systemd -- See https://hub.docker.com/_/centos/
-RUN yum -y swap -- remove fakesystemd -- install systemd systemd-libs
-RUN yum -y update; \
-(cd /lib/systemd/system/sysinit.target.wants/; for i in *; do [ $i == systemd-tmpfiles-setup.service ] || rm -f $i; done); \
-rm -f /lib/systemd/system/multi-user.target.wants/*; \
-rm -f /etc/systemd/system/*.wants/*; \
-rm -f /lib/systemd/system/local-fs.target.wants/*; \
-rm -f /lib/systemd/system/sockets.target.wants/*udev*; \
-rm -f /lib/systemd/system/sockets.target.wants/*initctl*; \
-rm -f /lib/systemd/system/basic.target.wants/*; \
-rm -f /lib/systemd/system/anaconda.target.wants/*;
-
-RUN yum -y install epel-release
-RUN yum -y install git ansible sudo
-
-RUN sed -i -e 's/^\(Defaults\s*requiretty\)/#--- \1/'  /etc/sudoers
-
-RUN echo -e '[local]\nlocalhost ansible_connection=local' > /etc/ansible/hosts
-
-VOLUME ["/sys/fs/cgroup"]
-
-CMD ["/usr/sbin/init"]

tests/dockerfiles/Dockerfile.debian-jessie

@@ -1,19 +0,0 @@
-FROM debian:jessie
-
-RUN apt-get update -y && apt-get install -y --no-install-recommends \
-    software-properties-common \
-    build-essential \
-    libffi-dev \
-    libssl-dev \
-    python-dev \
-    python-pip \
-    git \
-    apt-transport-https \
-    curl \
- && rm -rf /var/lib/apt/lists/*
-
-RUN pip install --upgrade setuptools && pip install ansible
-
-RUN mkdir -p /etc/ansible && echo "[local]\nlocalhost ansible_connection=local" > /etc/ansible/hosts
-
-ENTRYPOINT ["/sbin/init"]

tests/dockerfiles/Dockerfile.debian-stretch

@@ -1,22 +0,0 @@
-FROM debian:stretch
-
-RUN apt-get update -y && apt-get install -y --no-install-recommends \
-    software-properties-common \
-    build-essential \
-    libffi-dev \
-    libssl-dev \
-    python-dev \
-    python-pip \
-    git \
-    systemd \
-    apt-transport-https \
-    curl \
-    gnupg2 \
-    dirmngr \
- && rm -rf /var/lib/apt/lists/*
-
-RUN pip install --upgrade setuptools && pip install ansible
-
-RUN mkdir -p /etc/ansible && echo "[local]\nlocalhost ansible_connection=local" > /etc/ansible/hosts
-
-ENTRYPOINT ["/bin/systemd"]

tests/dockerfiles/Dockerfile.ubuntu-bionic

@@ -1,15 +0,0 @@
-FROM ubuntu:bionic
-
-RUN apt-get update && apt-get dist-upgrade -y && apt-get install -y software-properties-common && rm -rf /var/lib/apt/lists/*
-
-RUN apt-add-repository -y ppa:ansible/ansible && apt-get update && apt-get install -y \
-    git \
-    ansible \
-    apt-transport-https \
-    curl \
-    init \
- && rm -rf /var/lib/apt/lists/*
-
-RUN echo "[local]\nlocalhost ansible_connection=local" > /etc/ansible/hosts
-
-ENTRYPOINT ["/sbin/init"]

tests/dockerfiles/Dockerfile.ubuntu-trusty

@@ -1,14 +0,0 @@
-FROM ubuntu:trusty
-
-RUN apt-get update && apt-get dist-upgrade -y && apt-get install -y software-properties-common && rm -rf /var/lib/apt/lists/*
-
-RUN apt-add-repository -y ppa:ansible/ansible && apt-get update && apt-get install -y \
-    git \
-    ansible \
-    apt-transport-https \
-    curl \
- && rm -rf /var/lib/apt/lists/*
-
-RUN echo "[local]\nlocalhost ansible_connection=local" > /etc/ansible/hosts
-
-ENTRYPOINT ["/sbin/init"]

tests/dockerfiles/Dockerfile.ubuntu-xenial

@@ -1,14 +0,0 @@
-FROM ubuntu:xenial
-
-RUN apt-get update && apt-get dist-upgrade -y && apt-get install -y software-properties-common && rm -rf /var/lib/apt/lists/*
-
-RUN apt-add-repository -y ppa:ansible/ansible && apt-get update && apt-get install -y \
-    git \
-    ansible \
-    apt-transport-https \
-    curl \
- && rm -rf /var/lib/apt/lists/*
-
-RUN echo "[local]\nlocalhost ansible_connection=local" > /etc/ansible/hosts
-
-ENTRYPOINT ["/sbin/init"]

tests/playbooks/nginx-basic.yml

@@ -1,6 +0,0 @@
----
-- hosts: localhost
-  become: true
-  remote_user: root
-  roles:
-    - ansible-role-nginx

tests/playbooks/nginx-modules.yml

@@ -1,15 +0,0 @@
----
-- hosts: localhost
-  become: true
-  remote_user: root
-  roles:
-    - ansible-role-nginx
-  vars:
-    nginx_modules:
-      njs: true
-      perl: true
-      waf: false
-      geoip: true
-      image_filter: true
-      rtmp: true
-      xslt: true

tests/playbooks/nginx-push.yml

@@ -1,11 +0,0 @@
----
-- hosts: localhost
-  become: true
-  remote_user: root
-  roles:
-    - ansible-role-nginx
-  vars:
-    nginx_main_upload_enable: true
-    nginx_main_upload_src: ../files/nginx.conf
-    nginx_http_upload_enable: true
-    nginx_http_upload_src: ../files/http/*.conf

tests/playbooks/nginx-stable.yml

@@ -1,8 +0,0 @@
----
-- hosts: localhost
-  become: true
-  remote_user: root
-  roles:
-    - ansible-role-nginx
-  vars:
-    nginx_branch: stable

tests/playbooks/nginx-stream-template.yml

@@ -1,54 +0,0 @@
----
-- hosts: localhost
-  become: true
-  remote_user: root
-  roles:
-    - ansible-role-nginx
-  vars:
-    nginx_debug_output: true
-    nginx_main_template_enable: true
-    nginx_main_template:
-      template_file: nginx.conf.j2
-      conf_file_name: nginx.conf
-      conf_file_location: /etc/nginx/
-      user: nginx
-      worker_processes: auto
-      error_level: warn
-      worker_connections: 1024
-      http_enable: false
-      http_settings:
-        keepalive_timeout: 65
-        cache: false
-        rate_limit: false
-        keyval: false
-      stream_enable: true
-      http_global_autoindex: false
-    nginx_stream_template_enable: true
-    nginx_stream_template:
-      default:
-        template_file: stream/default.conf.j2
-        conf_file_name: default.conf
-        conf_file_location: /etc/nginx/conf.d/stream
-        network_streams:
-          app:
-            listen_address: localhost
-            listen_port: 80
-            udp_enable: false
-            proxy_pass: backend
-            proxy_timeout: 3s
-            proxy_connect_timeout: 1s
-            proxy_protocol: false
-            health_check_plus: false
-        upstreams:
-          backend_upstream:
-            name: backend
-            lb_method: least_conn
-            zone_name: backend
-            zone_size: 64k
-            sticky_cookie: false
-            servers:
-              backend_server_1:
-                address: localhost
-                port: 8080
-                weight: 1
-                health_check: max_fails=1 fail_timeout=10s