From 05d7af3c6ce64674e0c21f5dee3150b517254538 Mon Sep 17 00:00:00 2001 From: Ishan Jain <51803183+ishanjainn@users.noreply.github.com> Date: Thu, 10 Nov 2022 12:49:25 +0530 Subject: [PATCH] Add Note to modules which don't support Idempotency --- CHANGELOG.rst | 13 +++++++++++++ README.md | 2 +- changelogs/.plugin-cache.yaml | 2 +- changelogs/changelog.yaml | 6 ++++++ galaxy.yml | 2 +- plugins/modules/dashboard.py | 1 + plugins/modules/datasource.py | 1 + .../integration/targets/cloud_stack/tasks/main.yml | 12 ++++++------ 8 files changed, 30 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 7fb1444..972f04c 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -5,6 +5,19 @@ Grafana.Grafana Release Notes .. contents:: Topics +v1.0.5 +====== + +Release Summary +--------------- + +Add Note to modules which don't support Idempotency + +Minor Changes +------------- + +- Added Note to datasource and dashboard module about not supporting Idempotency + v1.0.4 ====== diff --git a/README.md b/README.md index f4bceb6..0504777 100644 --- a/README.md +++ b/README.md @@ -98,7 +98,7 @@ We plan to regularly release new minor or bugfix versions once new features or b Releasing the current major version on GitHub happens from the `main` branch by the [GitHub Release Workflow](https://github.com/grafana/grafana-ansible-collection/blob/main/.github/workflows/release.yml) Before the [GitHub Release Workflow](https://github.com/grafana/grafana-ansible-collection/blob/main/.github/workflows/release.yml) is run, Contributors should push the new version on Ansible Galaxy Manually. -We currently are not planning any deprecations or new major releases. The current landscape includes minor version updates for Module's documentation in 1.0.5. +We currently are not planning any deprecations or new major releases. The current landscape includes minor version updates for Module's documentation in 1.0.6. ## Code of Conduct This collection follows the Ansible project's [Code of Conduct](https://docs.ansible.com/ansible/devel/community/code_of_conduct.html). Please read and familiarize yourself with this doc diff --git a/changelogs/.plugin-cache.yaml b/changelogs/.plugin-cache.yaml index d3f2d84..a90b1e5 100644 --- a/changelogs/.plugin-cache.yaml +++ b/changelogs/.plugin-cache.yaml @@ -53,4 +53,4 @@ plugins: shell: {} strategy: {} vars: {} -version: 1.0.4 +version: 1.0.5 diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index 3d02a41..a973581 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -63,3 +63,9 @@ releases: when required library is missing from host release_summary: Bug fixes and idempotency fixes for modules release_date: '2022-11-01' + 1.0.5: + changes: + minor_changes: + - Added Note to datasource and dashboard module about not supporting Idempotency + release_summary: Add Note to modules which don't support Idempotency + release_date: '2022-11-10' diff --git a/galaxy.yml b/galaxy.yml index 1450c09..c117f46 100644 --- a/galaxy.yml +++ b/galaxy.yml @@ -1,6 +1,6 @@ namespace: grafana name: grafana -version: 1.0.4 +version: 1.0.5 readme: README.md authors: - Grafana Labs diff --git a/plugins/modules/dashboard.py b/plugins/modules/dashboard.py index 0214dc8..df8bb33 100644 --- a/plugins/modules/dashboard.py +++ b/plugins/modules/dashboard.py @@ -18,6 +18,7 @@ description: requirements: [ "requests >= 1.0.0" ] notes: - Does not support C(check_mode). + - Does not support C(Idempotency). options: dashboard: description: diff --git a/plugins/modules/datasource.py b/plugins/modules/datasource.py index 6ae0900..3c9d150 100644 --- a/plugins/modules/datasource.py +++ b/plugins/modules/datasource.py @@ -18,6 +18,7 @@ description: requirements: [ "requests >= 1.0.0" ] notes: - Does not support C(check_mode). + - Does not support C(Idempotency). options: dataSource: description: diff --git a/tests/integration/targets/cloud_stack/tasks/main.yml b/tests/integration/targets/cloud_stack/tasks/main.yml index 945833d..7b9ea98 100644 --- a/tests/integration/targets/cloud_stack/tasks/main.yml +++ b/tests/integration/targets/cloud_stack/tasks/main.yml @@ -1,7 +1,7 @@ - name: Create a Grafana Cloud stack grafana.grafana.cloud_stack: - name: ansiblestack - stack_slug: ansiblestack + name: ansiblestacktest + stack_slug: ansiblestacktest cloud_api_key: "{{ grafana_cloud_api_key }}" org_slug: "{{ org_name }}" state: present @@ -9,7 +9,7 @@ - assert: that: - - create_result.url == "https://ansiblestack.grafana.net" + - create_result.url == "https://ansiblestacktest.grafana.net" - name: Sleep for 30 seconds ansible.builtin.wait_for: @@ -17,8 +17,8 @@ - name: Delete a Grafana Cloud stack grafana.grafana.cloud_stack: - name: ansiblestack - stack_slug: ansiblestack + name: ansiblestacktest + stack_slug: ansiblestacktest cloud_api_key: "{{ grafana_cloud_api_key }}" org_slug: "{{ org_name }}" state: absent @@ -27,4 +27,4 @@ - assert: that: - delete_result.changed == true - - delete_result.url == "https://ansiblestack.grafana.net" \ No newline at end of file + - delete_result.url == "https://ansiblestacktest.grafana.net"